Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libidset: add missing bounds check #1975

Merged
merged 2 commits into from Jan 31, 2019

Conversation

@garlick
Copy link
Member

commented Jan 31, 2019

Add missing bounds check to idset_test() found by @grondo, and a regression test.

garlick added 2 commits Jan 31, 2019
Problem: idset_test() says an id equal to the size
(capacity) of the set is a member of the set.

Add a bounds check.

Fixes #1974
@codecov-io

This comment has been minimized.

Copy link

commented Jan 31, 2019

Codecov Report

Merging #1975 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1975      +/-   ##
==========================================
- Coverage   80.05%   80.02%   -0.03%     
==========================================
  Files         195      195              
  Lines       34986    34986              
==========================================
- Hits        28008    27999       -9     
- Misses       6978     6987       +9
Impacted Files Coverage Δ
src/common/libidset/idset.c 95.79% <100%> (ø) ⬆️
src/common/libflux/mrpc.c 87.74% <0%> (-1.19%) ⬇️
src/modules/connector-local/local.c 73.77% <0%> (-1.04%) ⬇️
src/modules/kvs-watch/kvs-watch.c 79.05% <0%> (-0.91%) ⬇️
src/broker/overlay.c 84.58% <0%> (-0.42%) ⬇️
src/cmd/flux-module.c 83.72% <0%> (-0.24%) ⬇️
src/common/libflux/message.c 81.27% <0%> (ø) ⬆️
src/modules/kvs/kvs.c 66.35% <0%> (+0.14%) ⬆️
src/common/libutil/dirwalk.c 94.4% <0%> (+0.69%) ⬆️
src/broker/modservice.c 79.8% <0%> (+0.96%) ⬆️
... and 1 more
@grondo

This comment has been minimized.

Copy link
Contributor

commented Jan 31, 2019

Thanks!!

@grondo grondo merged commit 096e89f into flux-framework:master Jan 31, 2019
3 checks passed
3 checks passed
codecov/patch 100% of diff hit (target 80.05%)
Details
codecov/project Absolute coverage decreased by -0.02% but relative coverage increased by +19.94% compared to fec80ad
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@garlick garlick deleted the garlick:idset_fix branch Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.