Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libidset: include stdbool.h in header #1978

Merged
merged 1 commit into from Feb 1, 2019

Conversation

@garlick
Copy link
Member

commented Feb 1, 2019

Problem: idset.h uses bool type without including its
definition, thus cannot be used standalone.

Include stdbool.h.

Fixes #1973

@codecov-io

This comment has been minimized.

Copy link

commented Feb 1, 2019

Codecov Report

Merging #1978 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #1978      +/-   ##
=========================================
- Coverage   80.01%     80%   -0.02%     
=========================================
  Files         195     195              
  Lines       35005   35005              
=========================================
- Hits        28009   28005       -4     
- Misses       6996    7000       +4
Impacted Files Coverage Δ
src/broker/modservice.c 78.84% <0%> (-0.97%) ⬇️
src/common/libflux/message.c 81.15% <0%> (-0.25%) ⬇️
src/cmd/flux-module.c 83.72% <0%> (-0.24%) ⬇️
@grondo

This comment has been minimized.

Copy link
Contributor

commented Feb 1, 2019

Thanks! Just needs ye olde rebase

Problem: idset.h uses bool type without including its
definition, thus cannot be used standalone.

Include stdbool.h.

Fixes #1973
@garlick garlick force-pushed the garlick:idset_include branch from 21b7240 to c73eab1 Feb 1, 2019
@garlick

This comment has been minimized.

Copy link
Member Author

commented Feb 1, 2019

Rebased.

@grondo grondo merged commit 50f435f into flux-framework:master Feb 1, 2019
2 of 3 checks passed
2 of 3 checks passed
codecov/project 80% (-0.02%) compared to bdb0fe0
Details
codecov/patch Coverage not affected when comparing bdb0fe0...c73eab1
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@grondo

This comment has been minimized.

Copy link
Contributor

commented Feb 1, 2019

Thanks!

@garlick garlick deleted the garlick:idset_include branch Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.