Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libflux/rpc: Add input parameter checks #1982

Merged
merged 1 commit into from Feb 1, 2019

Conversation

@chu11
Copy link
Contributor

commented Feb 1, 2019

Add input parameter checks to flux_rpc(), flux_rpc_raw(), and
flux_rpc_vpack(). NULL handle could lead to a segfault. Add
appropriate unit tests.

Fixes #1979

@codecov-io

This comment has been minimized.

Copy link

commented Feb 1, 2019

Codecov Report

Merging #1982 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1982      +/-   ##
==========================================
+ Coverage      80%   80.03%   +0.03%     
==========================================
  Files         195      195              
  Lines       35005    35014       +9     
==========================================
+ Hits        28006    28024      +18     
+ Misses       6999     6990       -9
Impacted Files Coverage Δ
src/common/libflux/rpc.c 93.37% <100%> (+0.37%) ⬆️
src/modules/barrier/barrier.c 76.55% <0%> (-2.07%) ⬇️
src/common/libflux/message.c 81.27% <0%> (ø) ⬆️
src/modules/connector-local/local.c 74.96% <0%> (+0.14%) ⬆️
src/modules/job-ingest/worker.c 72.72% <0%> (+7.69%) ⬆️
@garlick

This comment has been minimized.

Copy link
Member

commented Feb 1, 2019

Oh good, please rebase and let's get this merged.

Add input parameter checks to flux_rpc(), flux_rpc_raw(), and
flux_rpc_vpack().  NULL handle could lead to a segfault.  Add
appropriate unit tests.

Fixes #1979
@chu11

This comment has been minimized.

Copy link
Contributor Author

commented Feb 1, 2019

rebased

@garlick garlick merged commit 4eacf72 into flux-framework:master Feb 1, 2019
3 checks passed
3 checks passed
codecov/patch 100% of diff hit (target 80%)
Details
codecov/project 80.03% (+0.03%) compared to 50f435f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.