Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/flux-kvs: Create namespace subcommand #1985

Merged
merged 1 commit into from Feb 2, 2019

Conversation

@chu11
Copy link
Contributor

commented Feb 2, 2019

Convert namespace-create, namespace-remove, and namespace-list
into a general namespace subcommand with "create", "remove", and
"list" sub-sub-commands.

Fixes #1445

@codecov-io

This comment has been minimized.

Copy link

commented Feb 2, 2019

Codecov Report

Merging #1985 into master will decrease coverage by <.01%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #1985      +/-   ##
==========================================
- Coverage   80.16%   80.16%   -0.01%     
==========================================
  Files         195      195              
  Lines       35140    35149       +9     
==========================================
+ Hits        28170    28176       +6     
- Misses       6970     6973       +3
Impacted Files Coverage Δ
src/cmd/flux-kvs.c 83.07% <66.66%> (-0.16%) ⬇️
src/broker/modservice.c 78.84% <0%> (-0.97%) ⬇️
src/modules/kvs/kvs.c 66.33% <0%> (-0.15%) ⬇️
src/common/libflux/message.c 81.27% <0%> (-0.13%) ⬇️
src/cmd/flux-event.c 77.97% <0%> (ø) ⬆️
src/modules/connector-local/local.c 73.92% <0%> (+0.14%) ⬆️
src/common/libzio/zio.c 74.22% <0%> (+0.22%) ⬆️
src/common/libflux/response.c 82.71% <0%> (+1.23%) ⬆️
@chu11

This comment has been minimized.

Copy link
Contributor Author

commented Feb 2, 2019

diff target is bad, but it was all "impossible" error paths

@garlick

This comment has been minimized.

Copy link
Member

commented Feb 2, 2019

Looks good, just needs a rebase.

Convert namespace-create, namespace-remove, and namespace-list
into a general namespace subcommand with "create", "remove", and
"list" sub-sub-commands.

Fixes #1445
@chu11 chu11 force-pushed the chu11:issue1445 branch from c926c69 to 86eef22 Feb 2, 2019
@chu11

This comment has been minimized.

Copy link
Contributor Author

commented Feb 2, 2019

rebased

@garlick garlick merged commit 1c8fe20 into flux-framework:master Feb 2, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.