Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/flux-hwloc: fix double-free #1989

Merged
merged 1 commit into from Feb 4, 2019

Conversation

@garlick
Copy link
Member

commented Feb 4, 2019

Problem: flux-hwloc reload occasionally segfaults.

Drop an extra flux_future_destroy() call.

Fixes #1986.

Also, drop a redundant flux_future_get() call (cleanup).

Problem: flux-hwloc reload occasionally segfaults.

Drop an extra flux_future_destroy() call.

Fixes #1986.

Also, drop a redundant flux_future_get() call (cleanup).
@codecov-io

This comment has been minimized.

Copy link

commented Feb 4, 2019

Codecov Report

Merging #1989 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1989      +/-   ##
==========================================
- Coverage   80.16%   80.15%   -0.01%     
==========================================
  Files         195      195              
  Lines       35149    35146       -3     
==========================================
- Hits        28177    28173       -4     
- Misses       6972     6973       +1
Impacted Files Coverage Δ
src/cmd/builtin/hwloc.c 80.53% <ø> (+0.09%) ⬆️
src/common/libflux/response.c 81.48% <0%> (-1.24%) ⬇️
src/common/libzio/zio.c 74% <0%> (-0.23%) ⬇️
src/common/libflux/message.c 81.64% <0%> (+0.12%) ⬆️
@grondo

This comment has been minimized.

Copy link
Contributor

commented Feb 4, 2019

Needs more explanation. I didn't realize flux_kvs_commit was synchronous...

Oh uh, duh. Couldn't even read my own code right. Nevermind!

@grondo

This comment has been minimized.

Copy link
Contributor

commented Feb 4, 2019

Thanks!

@grondo grondo merged commit 8f22a2a into flux-framework:master Feb 4, 2019
2 of 3 checks passed
2 of 3 checks passed
codecov/project 80.15% (-0.01%) compared to 1c8fe20
Details
codecov/patch Coverage not affected when comparing 1c8fe20...3de36f6
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@garlick garlick deleted the garlick:hwloc_segfault branch Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.