Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

job-ingest: update rfc14 examples and jobspec schema to allow optional "max" property for resource counts #1996

Merged
merged 2 commits into from Feb 7, 2019

Conversation

@grondo
Copy link
Contributor

commented Feb 7, 2019

Update jobspec schema to make min the only required property for resource count specification. If any of max, operator, or operand are present, then all are required. (I think I got this right)

Update test input to latest examples from rfc14, which should now pass the validation tests in the testsuite.

Closes #1995

grondo added 2 commits Feb 7, 2019
Problem: rfc14 was recently updated to allow `min` without `max` to
be specified to indicate "infinite" maximum count. Some examples
were updated that would now fail the default jsonschema validator
in flux-core.

Update the schema to have "min" be the only required property of the
"complex_range" specification, but if any one of "max", "operator",
or "operand" are present, all must be.
Copy updated jobspec examples directly from rfc14 use cases.
@codecov-io

This comment has been minimized.

Copy link

commented Feb 7, 2019

Codecov Report

Merging #1996 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1996      +/-   ##
==========================================
- Coverage   80.17%   80.16%   -0.01%     
==========================================
  Files         195      195              
  Lines       35146    35146              
==========================================
- Hits        28177    28174       -3     
- Misses       6969     6972       +3
Impacted Files Coverage Δ
src/modules/barrier/barrier.c 76.55% <0%> (-2.07%) ⬇️
src/common/libflux/message.c 81.39% <0%> (-0.25%) ⬇️
src/modules/kvs/kvs.c 66.47% <0%> (+0.14%) ⬆️
@garlick

This comment has been minimized.

Copy link
Member

commented Feb 7, 2019

LGTM!

@garlick garlick merged commit ee43b86 into flux-framework:master Feb 7, 2019
2 of 3 checks passed
2 of 3 checks passed
codecov/project 80.16% (-0.01%) compared to fada14b
Details
codecov/patch Coverage not affected when comparing fada14b...9ae9ed9
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@grondo grondo deleted the grondo:jobspec-count-max-optional branch Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.