Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
cleanup: fix in-tree includes for idset.h, subprocess.h and other small fixes #2014
Just a few collected cleanups:
This is still a WIP because I'm not sure if my quick fix for the python bindings is even close to correct.
So the short story is: I think what you did, @grondo, is the right thing. The logner story: the
Related: I noticed that
Sorry, a play on that "Tidying Up" show -- KonMari is the method of tidying up and I looked up "puchi" --means something like "a little bit" in Japanese.
You are correct this should be added to subprocess.h. I actually had a fix for this in my branch, but dropped it along the way when trying out fixes for python bindings.
Problem: libsubprocess is compiled into libflux-core.so, but -- unlike core/kvs.h and core/job.h -- the header file subprocess.h has to be separately included into any source using that interface. Add subprocess.h to src/common/core.h *and* src/include/flux/core.h so that flux subprocess interfaces are automatically included with flux/core.h both in-tree and for installed flux-core.
libsubprocess is part of libflux-core.so, and thus, similar to kvs.h and job.h, its header subprocess.h should not be included directly when <flux/core.h> is already included. Remove redundant #includes of this header from throughout the flux-core codebase.
Codecov.io sometimes fails or takes a long time to report status back after a rebase. To avoid lengthy delays in merge of PRs, remove the codecov/project condition from mergify.yml. Reviewers will just have to ensure that coverage is acceptable before issuing a positive review or adding the merge-when-passing label. Also, fix the regex for matching PR titles that start with "wip", "WIP", "[wip", etc.
The references to cffi_modules _jsc_build.py:ffi and _kvs_build.py:ffi seem to be stale. Remove them.
@@ Coverage Diff @@ ## master #2014 +/- ## ========================================== - Coverage 80.58% 80.53% -0.05% ========================================== Files 180 180 Lines 28914 28914 ========================================== - Hits 23299 23286 -13 - Misses 5615 5628 +13
Looks good to me. The python thing is exactly where it belongs, and is the "right way" to handle that kind of thing so it can be portable. Thanks @grondo!…
On Fri, 15. Feb 17:56, Mark Grondona wrote: