Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t/kvs: fix racy possibility in kvs/transactionmerge #2022

Merged
merged 2 commits into from Feb 17, 2019

Conversation

@chu11
Copy link
Contributor

commented Feb 17, 2019

per discussion in #2021

chu11 added 2 commits Feb 15, 2019
Alter watcher thread to have a synchronous component, to ensure
kvs-watch watcher has been setup before commits begin.

Fixes #2021
With new watch initialization, there is no need for a watcher
thread, so refactor it out.
@codecov-io

This comment has been minimized.

Copy link

commented Feb 17, 2019

Codecov Report

Merging #2022 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2022      +/-   ##
==========================================
+ Coverage   80.58%   80.58%   +<.01%     
==========================================
  Files         180      180              
  Lines       28914    28914              
==========================================
+ Hits        23299    23301       +2     
+ Misses       5615     5613       -2
Impacted Files Coverage Δ
src/common/libflux/message.c 81.39% <0%> (-0.13%) ⬇️
src/broker/modservice.c 79.8% <0%> (ø) ⬆️
src/modules/barrier/barrier.c 78.62% <0%> (+2.06%) ⬆️
@garlick

This comment has been minimized.

Copy link
Member

commented Feb 17, 2019

LGTM thanks!

@garlick garlick merged commit e331bba into flux-framework:master Feb 17, 2019
4 checks passed
4 checks passed
Mergify — Summary 1 potential rule
Details
codecov/patch Coverage not affected when comparing bbe342a...6639d53
Details
codecov/project 80.58% (+<.01%) compared to bbe342a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.