Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis-ci: unshallow git repo before running docker #2028

Merged
merged 1 commit into from Feb 20, 2019

Conversation

@grondo
Copy link
Contributor

commented Feb 19, 2019

On travis-ci the version of git(1) inside of our docker image may
be too old for the git fetch --unshallow --tags to succeed, as
evidenced by errors like:

git fetch --unshallow --tags
fatal: unknown value for config 'protocol.version': 2

in our travis builds. To ensure we don't hit this error, run
the command to fetch tags before running docker, using the version
of git installed in travis.

Fixes #2024

On travis-ci the version of git(1) inside of our docker image may
be too old for the `git fetch --unshallow --tags` to succeed, as
evidenced by errors like:

 git fetch --unshallow --tags
 fatal: unknown value for config 'protocol.version': 2

in our travis builds. To ensure we don't hit this error, run
the command to fetch tags *before* running docker, using the version
of git installed in travis.

Fixes #2024
@garlick

This comment has been minimized.

Copy link
Member

commented Feb 19, 2019

Good catch!!! That one really had me puzzled.

@grondo

This comment has been minimized.

Copy link
Contributor Author

commented Feb 20, 2019

Hit a failure in t1004-kvs-namespace.t:

FAIL: t1004-kvs-namespace.t 47 - kvs: wait recognizes removed namespace
     t1004-kvs-namespace.t:  FAIL: N=52  PASS=51  FAIL=1 SKIP=0 XPASS=0 XFAIL=0
ERROR: t1004-kvs-namespace.t - exited with status 1
expecting success: 
        flux kvs namespace create $NAMESPACETMP-REMOVE-WAIT &&
        VERS=$(flux kvs version --namespace=$NAMESPACETMP-REMOVE-WAIT) &&
        VERS=$((VERS + 1)) &&
        flux kvs wait --namespace=$NAMESPACETMP-REMOVE-WAIT $VERS > wait_out 2>&1 &
        waitpid=$! &&
        wait_syncers_nonzero 1 $NAMESPACETMP-REMOVE-FENCE1 &&
        flux kvs namespace remove $NAMESPACETMP-REMOVE-WAIT &&
        ! wait $waitpid &&
        grep "flux_kvs_wait_version: Operation not supported" wait_out
flux-kvs: flux_kvs_get_version: Operation not supported
grep: wait_out: No such file or directory
not ok 47 - kvs: wait recognizes removed namespace
@garlick garlick merged commit 8dfc643 into flux-framework:master Feb 20, 2019
2 checks passed
2 checks passed
Mergify — Summary 1 potential rule
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@grondo

This comment has been minimized.

Copy link
Contributor Author

commented Feb 20, 2019

Thanks!

@grondo grondo deleted the grondo:issue#2024 branch Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.