Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t/kvs: Fix multiple minor issues in t1004-kvs-namespace.t #2034

Merged
merged 3 commits into from Feb 21, 2019

Conversation

@chu11
Copy link
Contributor

commented Feb 21, 2019

Most notably #2029

chu11 added 3 commits Feb 21, 2019
In addition to checking module stats, also check that command
completes successfully, to avoid racy situations.

Fixes #2029
@codecov-io

This comment has been minimized.

Copy link

commented Feb 21, 2019

Codecov Report

Merging #2034 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2034      +/-   ##
==========================================
+ Coverage   80.59%   80.62%   +0.02%     
==========================================
  Files         180      180              
  Lines       28966    28966              
==========================================
+ Hits        23345    23353       +8     
+ Misses       5621     5613       -8
Impacted Files Coverage Δ
src/cmd/flux-event.c 78.57% <0%> (+0.59%) ⬆️
src/modules/connector-local/local.c 74.66% <0%> (+1.03%) ⬆️
@chu11

This comment has been minimized.

Copy link
Contributor Author

commented Feb 21, 2019

ran through travis 3 times, no errors, so I think we can call this one fixed

@grondo

This comment has been minimized.

Copy link
Contributor

commented Feb 21, 2019

Great, thanks!

@grondo grondo merged commit b090c4b into flux-framework:master Feb 21, 2019
4 checks passed
4 checks passed
Mergify — Summary 1 potential rule
Details
codecov/patch Coverage not affected when comparing 8dfc643...599d65c
Details
codecov/project 80.62% (+0.02%) compared to 8dfc643
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.