Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: clean up idset_create(3) man page #2037

Merged
merged 3 commits into from Feb 22, 2019

Conversation

@garlick
Copy link
Member

commented Feb 22, 2019

Add a reference to the freshly minted RFC 22, fill in missing functions, and fix punctuation error.

garlick added 2 commits Feb 21, 2019
Problem: ID's is used repeatedly for the plural of ID.

Use IDs.
Copy link
Contributor

left a comment

Great! Just found one leftover use of apostrophe.

empty.

`idset_count()` returns the number of id's in the set.

This comment has been minimized.

Copy link
@grondo

grondo Feb 22, 2019

Contributor

Missed one! ✔️

This comment has been minimized.

Copy link
@garlick

garlick Feb 22, 2019

Author Member

Sigh. I added that one. Fixed.

Problem: manual page did not document all the functions
in the idset class.

Add prototypes and descriptions for
idset_copy()
idset_decode()
idset_encode()
idset_set()
idset_range_set()
idset_clear()
idset_range_clear()
idset_test()
idset_first()
idset_next()
idset_last()
idset_count()
@garlick garlick force-pushed the garlick:doc_cleanup branch from 7fd7590 to eb5f469 Feb 22, 2019
@codecov-io

This comment has been minimized.

Copy link

commented Feb 22, 2019

Codecov Report

Merging #2037 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2037      +/-   ##
==========================================
- Coverage    80.6%   80.59%   -0.02%     
==========================================
  Files         180      180              
  Lines       28966    28966              
==========================================
- Hits        23347    23344       -3     
- Misses       5619     5622       +3
Impacted Files Coverage Δ
src/modules/barrier/barrier.c 76.55% <0%> (-2.07%) ⬇️
src/broker/modservice.c 79.8% <0%> (-0.97%) ⬇️
src/common/libflux/message.c 81.39% <0%> (-0.13%) ⬇️
src/common/libutil/aux.c 94.44% <0%> (+3.7%) ⬆️
@grondo

This comment has been minimized.

Copy link
Contributor

commented Feb 22, 2019

Thanks!

@grondo grondo merged commit fdb8c6c into flux-framework:master Feb 22, 2019
4 checks passed
4 checks passed
Mergify — Summary 1 potential rule
Details
codecov/patch Coverage not affected when comparing b090c4b...eb5f469
Details
codecov/project 80.59% (-0.02%) compared to b090c4b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@garlick garlick deleted the garlick:doc_cleanup branch Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.