Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: prevent early garbage collection of flux handles #2046

Merged
merged 1 commit into from Feb 27, 2019

Conversation

@SteVwonder
Copy link
Member

commented Feb 26, 2019

Prevents early GC of Flux handles by tying the lifetime of a Flux object used to create an RPC to the RPC lifetime.

Closes #2045

@chu11

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2019

makes sense that this would fix this, just needs a rebase.

@SteVwonder SteVwonder force-pushed the SteVwonder:python-futures branch from 2db9950 to 55c547c Feb 27, 2019
@SteVwonder

This comment has been minimized.

Copy link
Member Author

commented Feb 27, 2019

Thanks @chu11. Rebased. Not sure why mergify didn't kick in and do the rebase automatically. I tried clicking on "details" but it just links directly to mergify.io rather than a PR-specific link 🤷‍♂

@codecov-io

This comment has been minimized.

Copy link

commented Feb 27, 2019

Codecov Report

Merging #2046 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2046      +/-   ##
==========================================
- Coverage   80.39%   80.39%   -0.01%     
==========================================
  Files         187      187              
  Lines       29435    29435              
==========================================
- Hits        23665    23663       -2     
- Misses       5770     5772       +2
Impacted Files Coverage Δ
src/broker/modservice.c 78.84% <0%> (-0.97%) ⬇️
src/common/libflux/message.c 81.39% <0%> (-0.13%) ⬇️
@chu11

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2019

ahh, i actually have to approve the PR as well as label it. Let me do that right now.

@chu11 chu11 self-requested a review Feb 27, 2019
@chu11
chu11 approved these changes Feb 27, 2019
@mergify mergify bot merged commit 66b980e into flux-framework:master Feb 27, 2019
4 checks passed
4 checks passed
Mergify — Summary 1 rule matches
Details
codecov/patch Coverage not affected when comparing 8104c17...55c547c
Details
codecov/project 80.39% (-0.01%) compared to 8104c17
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@grondo

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2019

To check on Mergify status, click the "Checks" tab and you will get a summary of conditions on which Mergify is waiting, and which are currently fulfilled. We haven't been using mergify lately because it doesn't auto-close mentioned issues when it merges PRs.

@SteVwonder SteVwonder deleted the SteVwonder:python-futures branch Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.