Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in sharness test for sched-simple #2053

Merged
merged 1 commit into from Feb 27, 2019

Conversation

@grondo
Copy link
Contributor

commented Feb 27, 2019

A bug crept in to the new timeout support for t2300-sched-simple.t -- I accidentally used date +%S instead of date +%s. This makes the test very unreliable if seconds roll over, so fix the test.

Unfortunately failed tests didn't start cropping up until after my PR was merged - sorry!

Problem: date `+%S` was used instead of `+%s` in computation of timeout
in t2300-sched-simple.t, resulting in failure or hang of the test if
the seconds rolled over during testing.

Fix the test to use `date +%s`.
@codecov-io

This comment has been minimized.

Copy link

commented Feb 27, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@fece4aa). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2053   +/-   ##
=========================================
  Coverage          ?   80.41%           
=========================================
  Files             ?      191           
  Lines             ?    30240           
  Branches          ?        0           
=========================================
  Hits              ?    24316           
  Misses            ?     5924           
  Partials          ?        0
@garlick garlick merged commit 7bf0343 into flux-framework:master Feb 27, 2019
4 checks passed
4 checks passed
Mergify — Summary 1 potential rule
Details
codecov/patch Coverage not affected.
Details
codecov/project No report found to compare against
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@grondo grondo deleted the grondo:t2300-sched-simple-fix branch Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.