Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules/kvs-watch: Fix consistency error #2064

Merged
merged 1 commit into from Mar 5, 2019

Conversation

@chu11
Copy link
Contributor

commented Mar 5, 2019

Ignore root sequences <= to the initial root sequence number, not
just < it.

Fixes #2063

Ignore root sequences <= to the initial root sequence number, not
just < it.

Fixes #2063
@chu11 chu11 force-pushed the chu11:issue2063 branch from 8480303 to 6573fd8 Mar 5, 2019
@garlick

This comment has been minimized.

Copy link
Member

commented Mar 5, 2019

Thanks- I've run that test in a loop for quite a while after applying this change with no failures. Will merge once travis passes.

@codecov-io

This comment has been minimized.

Copy link

commented Mar 5, 2019

Codecov Report

Merging #2064 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2064      +/-   ##
==========================================
+ Coverage   80.42%   80.43%   +0.01%     
==========================================
  Files         192      192              
  Lines       30345    30345              
==========================================
+ Hits        24404    24409       +5     
+ Misses       5941     5936       -5
Impacted Files Coverage Δ
src/modules/kvs-watch/kvs-watch.c 78.78% <100%> (ø) ⬆️
src/modules/barrier/barrier.c 76.55% <0%> (-2.07%) ⬇️
src/cmd/flux-event.c 78.57% <0%> (+0.59%) ⬆️
src/modules/connector-local/local.c 74.66% <0%> (+1.03%) ⬆️
@garlick garlick merged commit 220dfcd into flux-framework:master Mar 5, 2019
4 checks passed
4 checks passed
Mergify — Summary 1 potential rule
Details
codecov/patch 100% of diff hit (target 80.42%)
Details
codecov/project 80.43% (+0.01%) compared to 3a01140
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.