Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

job: misc fixes #2084

merged 5 commits into from Mar 19, 2019


Copy link

commented Mar 19, 2019

A few misc fixes I fixed along the way while working on #2076. The most notable one is requiring that all submit events in the eventlog must contain userid, priority, and flags. Faking a dummy submit even is no longer allowed.

chu11 added 5 commits Mar 14, 2019
For clarity, rename info_parse_next to eventlog_parse_next.
Use the flux_job_kvs_key() to generate kvs keys instead of
doing it by hand.  Remove now unnecessary struct members, and
as a result remove job_assign_id() function.
util_attr_lookup() was only used in one place.  Replace call with
call to flux_job_kvs_key() and flux_kvs_lookup() and remove
the function.
When calling event_job_update() with the "submit" event, do not
create a simplified/fake submit event.  Re-create the full submit

As a result, event_job_update() does not expect a "submit" event
may not include its context data.  Any submit event that does not
have all context data is an error.
@chu11 chu11 force-pushed the chu11:issue2076_pre_misc_fixes branch from aeaf0fb to 7084a00 Mar 19, 2019

This comment has been minimized.

Copy link

commented Mar 19, 2019

Codecov Report

Merging #2084 into master will decrease coverage by <.01%.
The diff coverage is 86.66%.

@@            Coverage Diff             @@
##           master    #2084      +/-   ##
- Coverage   80.44%   80.44%   -0.01%     
  Files         193      193              
  Lines       30540    30532       -8     
- Hits        24569    24560       -9     
- Misses       5971     5972       +1
Impacted Files Coverage Δ
src/modules/job-manager/util.c 87.03% <ø> (+2.29%) ⬆️
src/modules/job-manager/event.c 73.54% <100%> (ø) ⬆️
src/modules/job-manager/submit.c 67.24% <100%> (+0.57%) ⬆️
src/modules/job-info/job-info.c 68% <100%> (ø) ⬆️
src/modules/job-ingest/job-ingest.c 73.33% <100%> (+0.77%) ⬆️
src/modules/job-manager/restart.c 84.05% <50%> (-2.31%) ⬇️
src/common/libutil/aux.c 90.74% <0%> (-3.71%) ⬇️
src/common/libflux/mrpc.c 87.74% <0%> (-1.19%) ⬇️

This comment has been minimized.

Copy link

commented Mar 19, 2019

LGTM! Thanks @chu11!

@garlick garlick merged commit 761b475 into flux-framework:master Mar 19, 2019
4 checks passed
4 checks passed
Mergify — Summary 1 potential rule
codecov/patch 86.66% of diff hit (target 80.44%)
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +6.21% compared to 0afdf79
continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.