Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/flux-ping: exit(1) immediately on error #2090

Merged
merged 1 commit into from Mar 21, 2019

Conversation

@garlick
Copy link
Member

commented Mar 20, 2019

Problem: flux-ping exits indicating success even when
it receives an obviously fatal failure response,
such as ENOSYS.

Just have ping call err_exit() upon receiving any
kind of error response.

Update sharness ping test.

Fixes #2087

Problem: flux-ping exits indicating success even when
it receives an obviously fatal failure response,
such as ENOSYS.

Just have ping call err_exit() upon receiving any
kind of error response.

Update sharness ping test.

Fixes #2087
@codecov-io

This comment has been minimized.

Copy link

commented Mar 20, 2019

Codecov Report

Merging #2090 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2090      +/-   ##
==========================================
- Coverage    80.4%   80.37%   -0.04%     
==========================================
  Files         192      192              
  Lines       30564    30563       -1     
==========================================
- Hits        24574    24564      -10     
- Misses       5990     5999       +9
Impacted Files Coverage Δ
src/cmd/flux-ping.c 86.95% <100%> (-0.1%) ⬇️
src/modules/connector-local/local.c 73.62% <0%> (-1.04%) ⬇️
src/broker/modservice.c 78.84% <0%> (-0.97%) ⬇️
src/cmd/flux-module.c 83.72% <0%> (-0.24%) ⬇️
src/common/libflux/message.c 81.39% <0%> (-0.13%) ⬇️
src/broker/overlay.c 85% <0%> (+0.41%) ⬆️
@chu11

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

pretty straight forward, LGTM

@chu11 chu11 merged commit 909d9cc into flux-framework:master Mar 21, 2019
4 checks passed
4 checks passed
Mergify — Summary 1 potential rule
Details
codecov/patch 100% of diff hit (target 80.4%)
Details
codecov/project Absolute coverage decreased by -0.03% but relative coverage increased by +19.59% compared to 4e44bc0
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@garlick garlick deleted the garlick:ping_fatal branch Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.