Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
jobspec: make attributes.system.duration a number of seconds #2096
Update the jobspec attribute.system.duration to a strict number of seconds rather than an arbitrary string. Update all use cases, tests, scripts, and readers of jobspec. Unfortunately this must be done all at once to avoid mid-commit breakage.
@@ Coverage Diff @@ ## master #2096 +/- ## ========================================= + Coverage 80.29% 80.3% +0.01% ========================================= Files 196 196 Lines 31311 31315 +4 ========================================= + Hits 25140 25147 +7 + Misses 6171 6168 -3
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews.