Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libflux: Add error string to continue error #2097

Merged
merged 1 commit into from Mar 22, 2019

Conversation

@chu11
Copy link
Contributor

commented Mar 22, 2019

Add error string parameter to flux_future_continue_error() so an
optional error string an be set on the future.

Update callers appropriately and add unit tests.

Fixes #2079

Add error string parameter to flux_future_continue_error() so an
optional error string an be set on the future.

Update callers appropriately and add unit tests.

Fixes #2079
@codecov-io

This comment has been minimized.

Copy link

commented Mar 22, 2019

Codecov Report

Merging #2097 into master will increase coverage by <.01%.
The diff coverage is 20%.

@@            Coverage Diff             @@
##           master    #2097      +/-   ##
==========================================
+ Coverage   80.28%   80.28%   +<.01%     
==========================================
  Files         195      195              
  Lines       31291    31291              
==========================================
+ Hits        25121    25122       +1     
+ Misses       6170     6169       -1
Impacted Files Coverage Δ
src/common/libkvs/kvs_copy.c 75.9% <0%> (ø) ⬆️
src/modules/job-exec/job-exec.c 73.81% <0%> (ø) ⬆️
src/common/libflux/composite_future.c 80.95% <100%> (ø) ⬆️
src/common/libutil/aux.c 90.74% <0%> (-3.71%) ⬇️
src/cmd/flux-module.c 83.96% <0%> (+0.23%) ⬆️
src/common/libflux/message.c 81.39% <0%> (+0.24%) ⬆️
@grondo

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2019

Since all the (non-testing) changes here are by definition in error handling code, it isn't too surprising the coverage is only 20%.

Looks good and thanks @chu11!

@grondo grondo merged commit 31fbac6 into flux-framework:master Mar 22, 2019
3 of 4 checks passed
3 of 4 checks passed
codecov/patch 20% of diff hit (target 80.28%)
Details
Mergify — Summary 1 potential rule
Details
codecov/project 80.28% (+<.01%) compared to 1a02303
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.