Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
build/test: fix asciidoc build in travis and run_timeout() macro + misc test fixes #2104
Problem: The check for asciidoctor version >= 1.5.7 was flawed in some way, and failed to grab the version in some or all circumstances. This caused the build of docs to be silently disabled in Travis-CI for example. Simplify the sed(1) expression used to grab the asciidoctor version for `asciidoctor --version` output (tested working). Furthermore, add a surrounding AC_MSG_CHECKING/AC_MSG_RESULT block so that the detected version is printed in output for aid in future debugging efforts. Fixes #2102
If --enable-docs or --enable-docs=yes is used in configure, fail ./configure with an error when no asciidoc generator is found, instead of auto-disabling documentation. This provides a mode to build docs or fail during CI runs or package building, instead of silently disabling documention.
Always add --enable-docs to travis-ci builds to force an error if, for some reason, an asciidoc formatter is not found (instead of silently disabling docs)
Problem: scripts are repeated in t/Makefile.am, and some scripts are included in the dist via EXTRA_DIST, and others via dist_check_SCRIPTS. Drop scripts from EXTRA_DIST and put all scripts in dist_check_SCRIPTS. Factor out TESTSCRIPTS, and include that in both TESTS (the scripts and programs that are run as TAP tests) and dist_check_SCRIPTS. Also for clarity: - move clean-local target up with other un-magical make targets. - Move check_PROGRAMS += addition near check_PROGRAMS. Fixes #2101
In the test for job-manager.exec-hello failure when jobs still exist with outstanding start requests, a `run_timeout` was used to execute a `test_must_fail` shell function, which clearly cannot work. Since we still want to be able to time out the script that is trying to register with the job-manager (since a failure would hang forever), use `test_expect_code 1` to differentiate between a timeout and an expected failure.
@@ Coverage Diff @@ ## master #2104 +/- ## ========================================== + Coverage 80.3% 80.36% +0.06% ========================================== Files 196 196 Lines 31320 31320 ========================================== + Hits 25150 25169 +19 + Misses 6170 6151 -19
Actually I have one other fix that could be pushed here if that is OK @garlick.
I noticed many sharness tests are missing this code to append
# Append --logfile option if FLUX_TESTS_LOGFILE is set in environment: test -n "$FLUX_TESTS_LOGFILE" && set -- "$@" --logfile
We could update the missing tests here. This really only affects Travis which runs with