Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
job-info: refactor #2112
Make common function to move the entire active directory to inactive rather than just one path. Most tests do not need to move just the one key.
When submitting jobs in t2204-job-info and t2205-job-info-security, immediately cancel the job and wait for the clean event. This ensures that no other changes will occur to the eventlog and all test manipulation of the eventlog will be safe.
Instead of passing a flag to job-info.eventlog-lookup to watch an eventlog, create a new RPC target job-info.eventlog-watch. Remove job info flags in watch as a result, adjust rpc results that are returned to callers.
Split eventlog lookup & watch infrastructure into two distinct sets of functions / callbacks. This is in prepration for lookups of job data beyond just the eventlog.
Rename job-info.eventlog-lookup target to job-info.lookup. The key name (e.g. eventlog) for the job is sent in the rpc request instead of being assumed by the target. Make lookup_key() function take key name for construction of path to lookup in KVS.
@@ Coverage Diff @@ ## master #2112 +/- ## ========================================== - Coverage 80.29% 80.26% -0.04% ========================================== Files 197 201 +4 Lines 31546 31618 +72 ========================================== + Hits 25331 25377 +46 - Misses 6215 6241 +26
garlick merged commit
Apr 4, 2019
3 of 4 checks passed
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews.