Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
job-info: Allow reading more than eventlog #2114
In main lookup cb, pre-check that the owner of the instance sent the RPC, which allows us to remove a guest access check for future job info retrieval.
@@ Coverage Diff @@ ## master #2114 +/- ## ========================================== + Coverage 80.23% 80.27% +0.03% ========================================== Files 201 201 Lines 31618 31663 +45 ========================================== + Hits 25369 25417 +48 + Misses 6249 6246 -3
LGTM, and I think all stuff we discussed in #2107 so merging.
It's not part of this PR but one thing offhand I noticed just now when merging is the job tests are setting
Doh! Good catch, will fix in next PR.