Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc RFC18 fixes / cleanups / refactorings #2126

Merged
merged 5 commits into from Apr 16, 2019

Conversation

@chu11
Copy link
Contributor

commented Apr 15, 2019

Peeled off from #2117, just misc fixes before the bigger #2106 fixes.

@garlick

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

Do we really want to drop flux kvs eventlog --watch? That seems kind of useful.

@chu11

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2019

Do we really want to drop flux kvs eventlog --watch? That seems kind of useful.

It wasn't used anywhere so I wasn't sure of the need. But if you think it still has promise, I'll revert it.

@garlick

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

I vote we keep it for now.

chu11 added 5 commits Apr 8, 2019
Create eventlog_unformatted_print() function to abstract away
printing.  Do not pass 'stdout' to eventlog_prettyprint(), it is
unnecessary.
@chu11 chu11 force-pushed the chu11:issue2106_part1 branch from c4becf7 to 02e418a Apr 16, 2019
@chu11

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2019

ok, rebased & repushed with the --watch removal commit taken out.

@codecov-io

This comment has been minimized.

Copy link

commented Apr 16, 2019

Codecov Report

Merging #2126 into master will increase coverage by 0.02%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master    #2126      +/-   ##
==========================================
+ Coverage    80.2%   80.22%   +0.02%     
==========================================
  Files         201      201              
  Lines       31731    31733       +2     
==========================================
+ Hits        25450    25459       +9     
+ Misses       6281     6274       -7
Impacted Files Coverage Δ
src/cmd/flux-kvs.c 82.2% <80%> (-0.08%) ⬇️
src/common/libflux/mrpc.c 87.74% <0%> (-1.19%) ⬇️
src/modules/connector-local/local.c 73.62% <0%> (-0.89%) ⬇️
src/cmd/flux-event.c 77.97% <0%> (ø) ⬆️
src/cmd/flux-module.c 83.72% <0%> (ø) ⬆️
src/common/libflux/reactor.c 92.08% <0%> (+0.22%) ⬆️
src/common/libflux/message.c 81.51% <0%> (+0.24%) ⬆️
src/common/libflux/handle.c 83.71% <0%> (+0.45%) ⬆️
src/cmd/flux-job.c 84.76% <0%> (+0.49%) ⬆️
src/common/libutil/veb.c 98.85% <0%> (+0.57%) ⬆️
... and 5 more
@garlick

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

LGTM - thanks!

@garlick garlick merged commit adce7f6 into flux-framework:master Apr 16, 2019
3 of 4 checks passed
3 of 4 checks passed
codecov/patch 80% of diff hit (target 80.2%)
Details
Mergify — Summary 1 potential rule
Details
codecov/project 80.22% (+0.02%) compared to 2c126f3
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.