Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove job.active/inactive directory #2146

Merged
merged 8 commits into from May 5, 2019

Conversation

@chu11
Copy link
Contributor

commented May 3, 2019

As discussed in #2107 and #2093, remove the job.active and job.inactive directories, instead putting all job information simply in the job directory.

This is first step towards more work. Future work to archive inactive jobs TBD.

chu11 added 8 commits May 1, 2019
flux_job_kvs_key() did not set an errno when a buffer overflowed.  Set
errno = EOVERFLOW if it occurs.
flux_job_kvs_key() checks for NULL keys and buffer overflow, so there is
no need to check for it in make_key().
Based on changes to RFC16, the active/inactive directory no longer exists
in the job kvs directory.  So remove the active flag for flux_job_kvs_key()
indicating if the path is active/inactive.

Adjust callers accordingly.
Update for removal of job.active directory.
With removal of job.active and job.inactive, remove code dealing
with movement of jobs from active to inactive directory.

Also remove job-info tests related to this.
Update documentation given removal of job.active & job.inactive.
With removal of job.active and job.inactive, the flux job id
option 'kvs-active' no longer makes sense.  Rename it to 'kvs'.

Adjust callers accordingly.
@codecov-io

This comment has been minimized.

Copy link

commented May 3, 2019

Codecov Report

Merging #2146 into master will decrease coverage by 0.02%.
The diff coverage is 84.37%.

@@            Coverage Diff             @@
##           master    #2146      +/-   ##
==========================================
- Coverage   80.46%   80.43%   -0.03%     
==========================================
  Files         200      200              
  Lines       31781    31756      -25     
==========================================
- Hits        25572    25543      -29     
- Misses       6209     6213       +4
Impacted Files Coverage Δ
src/modules/job-manager/restart.c 84.05% <100%> (ø) ⬆️
src/modules/job-manager/event.c 74.77% <100%> (ø) ⬆️
src/common/libschedutil/ops.c 58.92% <100%> (ø) ⬆️
src/modules/job-ingest/job-ingest.c 74.32% <100%> (-0.1%) ⬇️
src/modules/job-exec/job-exec.c 74.36% <100%> (ø) ⬆️
src/common/libschedutil/hello.c 59.25% <100%> (ø) ⬆️
src/common/libjob/job.c 76.59% <100%> (+0.16%) ⬆️
src/cmd/flux-job.c 86.36% <100%> (-0.25%) ⬇️
src/common/libschedutil/alloc.c 69.64% <100%> (ø) ⬆️
src/modules/job-info/lookup.c 65.11% <40%> (-2.75%) ⬇️
... and 10 more
@garlick

This comment has been minimized.

Copy link
Member

commented May 5, 2019

This looks very clean - nice job.

I'll push the button and then we'll want to have a discussion about next steps during the week.

Thanks!

@garlick garlick merged commit ff46e3d into flux-framework:master May 5, 2019
4 checks passed
4 checks passed
Summary 1 potential rule
Details
codecov/patch 84.37% of diff hit (target 80.46%)
Details
codecov/project Absolute coverage decreased by -0.02% but relative coverage increased by +3.91% compared to bf2b9d7
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
chu11 added a commit to chu11/flux-core that referenced this pull request Aug 14, 2019
Active / inactive jobs were removed in PR flux-framework#2146.  Remove use of
variable names with "active" in them.

Legacy variable name "activekvsdir" is used, but active / inactive
directories were removed in
chu11 added a commit to chu11/flux-core that referenced this pull request Aug 14, 2019
Active / inactive jobs were removed in PR flux-framework#2146.  Remove use of
variable names with "active" in them.

Legacy variable name "activekvsdir" is used, but active / inactive
directories were removed in
chu11 added a commit to chu11/flux-core that referenced this pull request Aug 15, 2019
Active / inactive jobs were removed in PR flux-framework#2146.  Remove use of
variable names with "active" in them.

Legacy variable name "activekvsdir" is used, but active / inactive
directories were removed in
chu11 added a commit to chu11/flux-core that referenced this pull request Aug 15, 2019
Active / inactive jobs were removed in PR flux-framework#2146.  Remove use of
variable names with "active" in them.

Legacy variable name "activekvsdir" is used, but active / inactive
directories were removed in
chu11 added a commit to chu11/flux-core that referenced this pull request Aug 16, 2019
Active / inactive jobs were removed in PR flux-framework#2146.  Remove use of
variable names with "active" in them.

Legacy variable name "activekvsdir" is used, but active / inactive
directories were removed in
chu11 added a commit to chu11/flux-core that referenced this pull request Aug 16, 2019
Active / inactive jobs were removed in PR flux-framework#2146.  Remove use of
variable names with "active" in them.

Legacy variable name "activekvsdir" is used, but active / inactive
directories were removed in
chu11 added a commit to chu11/flux-core that referenced this pull request Aug 18, 2019
Active / inactive jobs were removed in PR flux-framework#2146.  Remove use of
variable names with "active" in them.

Legacy variable name "activekvsdir" is used, but active / inactive
directories were removed in
chu11 added a commit to chu11/flux-core that referenced this pull request Aug 20, 2019
Active / inactive jobs were removed in PR flux-framework#2146.  Remove use of
variable names with "active" in them.

Legacy variable name "activekvsdir" is used, but active / inactive
directories were removed in
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.