Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libsubprocess: Remove STARTED state #2167

Merged
merged 1 commit into from May 30, 2019

Conversation

@chu11
Copy link
Contributor

commented May 20, 2019

Remove the "Started" state, which serves little purpose, especially
after the addition of pre-exec and post-fork hooks.

Update all uses of the Started state outside of libsubprocess.

Fixes #2154

Remove the "Started" state, which serves little purpose, especially
after the addition of pre-exec and post-fork hooks.

Update all uses of the Started state outside of libsubprocess.

Fixes #2154
@chu11 chu11 force-pushed the chu11:issue2154 branch from f9af0fd to 751ae2b May 22, 2019
@chu11

This comment has been minimized.

Copy link
Contributor Author

commented May 22, 2019

rebased

@codecov-io

This comment has been minimized.

Copy link

commented May 22, 2019

Codecov Report

Merging #2167 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2167      +/-   ##
==========================================
+ Coverage   80.47%   80.47%   +<.01%     
==========================================
  Files         200      200              
  Lines       31840    31828      -12     
==========================================
- Hits        25623    25615       -8     
+ Misses       6217     6213       -4
Impacted Files Coverage Δ
src/cmd/flux-exec.c 75.67% <ø> (-0.11%) ⬇️
src/common/libsubprocess/local.c 76.65% <ø> (-0.09%) ⬇️
src/modules/job-ingest/worker.c 65.03% <ø> (ø) ⬆️
src/common/libsubprocess/remote.c 70.12% <100%> (-0.1%) ⬇️
src/common/libsubprocess/server.c 71.14% <100%> (+0.27%) ⬆️
src/modules/cron/task.c 79.31% <100%> (ø) ⬆️
src/common/libsubprocess/subprocess.c 87.19% <100%> (-0.13%) ⬇️
src/common/libflux/mrpc.c 87.79% <0%> (-1.19%) ⬇️
src/cmd/flux-module.c 83.96% <0%> (ø) ⬆️
... and 2 more
@grondo

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

Sorry @chu11 for letting this one languish. Is this ready to go in? Looks fine to me.

@chu11

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

yup

@grondo grondo merged commit d62f93a into flux-framework:master May 30, 2019
4 checks passed
4 checks passed
Summary 1 potential rule
Details
codecov/patch 100% of diff hit (target 80.47%)
Details
codecov/project 80.47% (+<.01%) compared to af0ec65
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.