Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broker: remove many ooms and xzmalloc/xstrdup/xasprintf calls #2197

Merged
merged 3 commits into from Jun 25, 2019

Conversation

@chu11
Copy link
Contributor

commented Jun 17, 2019

Final cleanup/refactor before I would something big as discussed in #2182. Can discuss if #2182 is something we want to go down the path of or if we should hold out on that work.

@chu11

This comment has been minimized.

Copy link
Contributor Author

commented Jun 17, 2019

ugh, bad @chu11, I forgot to run make check before pushing. BRB.

@chu11 chu11 force-pushed the chu11:broker_refactor_2 branch from 92a009a to fe95899 Jun 17, 2019
@chu11

This comment has been minimized.

Copy link
Contributor Author

commented Jun 17, 2019

re-pushed with fixes

@codecov-io

This comment has been minimized.

Copy link

commented Jun 17, 2019

Codecov Report

Merging #2197 into master will decrease coverage by 0.18%.
The diff coverage is 50.74%.

@@            Coverage Diff             @@
##           master    #2197      +/-   ##
==========================================
- Coverage   80.86%   80.68%   -0.19%     
==========================================
  Files         199      199              
  Lines       31815    31899      +84     
==========================================
+ Hits        25728    25738      +10     
- Misses       6087     6161      +74
Impacted Files Coverage Δ
src/broker/heartbeat.c 86.15% <ø> (ø) ⬆️
src/broker/runlevel.c 80.68% <ø> (ø) ⬆️
src/broker/shutdown.c 77.77% <ø> (ø) ⬆️
src/broker/hello.c 76.27% <ø> (ø) ⬆️
src/broker/service.c 82.47% <ø> (ø) ⬆️
src/broker/broker.c 73.5% <100%> (-0.25%) ⬇️
src/broker/content-cache.c 74.77% <100%> (ø) ⬆️
src/broker/boot_pmi.c 63.63% <33.33%> (-4.44%) ⬇️
src/broker/boot_config.c 85.54% <33.33%> (-4.34%) ⬇️
src/broker/modservice.c 70.67% <33.33%> (-2.97%) ⬇️
... and 10 more
@garlick

This comment has been minimized.

Copy link
Member

commented Jun 23, 2019

LGTM. Needs a rebase.

Can discuss if #2182 is something we want to go down the path of or if we should hold out on that work.

In face to face planning we decided to put this off (for the online record).

chu11 added 3 commits Jun 14, 2019
When appropriate, return error, cleanup in function, etc.  Update
callers if necessary.
Replace calls to xzmalloc(), xstrdup(), and xasprintf() when appropriate
and return errors to callers.
@chu11 chu11 force-pushed the chu11:broker_refactor_2 branch from fe95899 to adda2a8 Jun 24, 2019
@chu11

This comment has been minimized.

Copy link
Contributor Author

commented Jun 24, 2019

rebased and repushed

@garlick

This comment has been minimized.

Copy link
Member

commented Jun 25, 2019

Thanks!

@garlick garlick merged commit e0a2d53 into flux-framework:master Jun 25, 2019
2 checks passed
2 checks passed
Summary 1 potential rule
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.