Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: update centos7 image to python3.6 and add valgrind-devel #2221

Merged
merged 3 commits into from Jul 10, 2019

Conversation

@grondo
Copy link
Contributor

commented Jul 10, 2019

Problem: without the valgrind-devel package, valgrind.h is not found
during configure and the valgrind test is disabled by default. When
run with -d, the t5000-valgrind.t is forced to run, but may encounter
false positives and bad stack traces due to modules that are dlclosed.

Add valgrind-devel to the centos7 docker image. (valgrind.h is part of
the base valgrind package in Ubuntu)

Problem: without the valgrind-devel package, valgrind.h is not found
during configure and the valgrind test is disabled by default. When
run with -d, the t5000-valgrind.t is forced to run, but may encounter
false positives and bad stack traces due to modules that are dlclosed.

Add valgrind-devel to the centos7 docker image. (valgrind.h is part of
the base valgrind package in Ubuntu)
@grondo

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2019

A new docker image for centos7 has been built and pushed up to dockerhub already.

@garlick

This comment has been minimized.

Copy link
Member

commented Jul 10, 2019

Thanks! Probably should update the redhat column in README.md. It only lists the valgrind package right now.

@grondo

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2019

@garlick

This comment has been minimized.

Copy link
Member

commented Jul 10, 2019

There's a little annotation in there that it is an optional test requirement, FWIW.

@grondo

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2019

Ah, ok! Sorry I didn't even actually check the list, duh.

I'll add a commit here to add valgrind-devel to the list for redhat. Thanks.

@grondo

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2019

Hm, the updated centos7 image seems to have broken the python 3.4 build:

configure:14902: checking for cffi.__version_info__ >= (1,1) in python module cffi
Traceback (most recent call last):
  File "<string>", line 4, in <module>
ImportError: No module named 'cffi'
configure:14929: result: no
configure:14931: error: could not find python module cffi, version 1.1+ required

I'll see if I can fix this asap.

@grondo

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2019

Oh, I forgot that RHEL7/centos7 had moved python3 from python3.4 to python3.6. By recreating the centos7 docker image I inadvertently updated to a version where we don't have required python3.4 packages.

On our TOSS systems we've also updated python3 to python3.6. I can try moving our Travis PYTHON_VERSION=3.4 tests to PYTHON_VERSION=3.6 if that is ok with @SteVwonder and @trws?

@SteVwonder

This comment has been minimized.

Copy link
Member

commented Jul 10, 2019

On our TOSS systems we've also updated python3 to python3.6. I can try moving our Travis PYTHON_VERSION=3.4 tests to PYTHON_VERSION=3.6 if that is ok with @SteVwonder and @trws?

Works for me 😄

grondo added 2 commits Jul 10, 2019
Latest versions of RHEL7/CentOS7 updated python 3.4 to 3.6.

Update our tests accordingly now that the testenv:centos7
docker image has been updated to python 3.6.
Update python3 version in centos7 "testenv" docker image to
python3.6, since Centos moved to this version by default.
@grondo grondo changed the title docker: add valgrind-devel to centos7 Dockerfile docker: update centos7 image to python3.6 and add valgrind-devel Jul 10, 2019
@grondo

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2019

Ok, done (pushed new docker image to docker hub as well), and updated the title of this PR accordingly.

@garlick

This comment has been minimized.

Copy link
Member

commented Jul 10, 2019

Thank you! Looks great to me.

@garlick garlick merged commit fe713fe into flux-framework:master Jul 10, 2019
2 checks passed
2 checks passed
Summary 1 potential rule
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@grondo grondo deleted the grondo:docker-valgrind-devel branch Jul 10, 2019
@trws

This comment has been minimized.

Copy link
Member

commented Jul 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.