Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t/barrier: Remove tbarrier executable #2229

Merged
merged 1 commit into from Jul 12, 2019

Conversation

@chu11
Copy link
Contributor

commented Jul 12, 2019

The executable seems to have been accidentally commited in

bd17941

@garlick

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

Sorry, that was sloppy! It was 6e8a593 FWIW, same PR. Will merge once travis turns green.

@chu11

This comment has been minimized.

Copy link
Contributor Author

commented Jul 12, 2019

oops, cut & pasted the wrong commit. I'll change the message.

The executable seems to have been accidentally commited in

6e8a593
@chu11 chu11 force-pushed the chu11:remove_tbarrier_exectuable branch from 99df0c7 to 337cc62 Jul 12, 2019
@codecov-io

This comment has been minimized.

Copy link

commented Jul 12, 2019

Codecov Report

Merging #2229 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #2229      +/-   ##
=========================================
+ Coverage    80.7%   80.7%   +<.01%     
=========================================
  Files         202     202              
  Lines       32295   32295              
=========================================
+ Hits        26064   26065       +1     
+ Misses       6231    6230       -1
Impacted Files Coverage Δ
src/common/libflux/message.c 80.62% <0%> (-0.26%) ⬇️
src/common/libflux/mrpc.c 88.97% <0%> (+1.18%) ⬆️
@grondo

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2019

Thanks, I just kept blindly deleting it thinking it was a byproduct of switching branches. 😕

@grondo grondo merged commit cba3138 into flux-framework:master Jul 12, 2019
4 checks passed
4 checks passed
Summary 1 potential rule
Details
codecov/patch Coverage not affected when comparing 3496084...337cc62
Details
codecov/project 80.7% (+<.01%) compared to 3496084
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@garlick

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

Thanks, again sorry. Sheesh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.