Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libsubprocess: Add new EOF reached function #2254

Merged
merged 3 commits into from Jul 22, 2019

Conversation

@chu11
Copy link
Contributor

commented Jul 22, 2019

This is a cleaned up version of #2245 which is cleaned up/merge-able. It is a temporary solution to #2239 until that can be completed and should allow #2246 to be merged in.

I'll let it be @garlick's decision if he wishes to cherry pick this into his branch or if should be merged into master via this PR.

chu11 added 3 commits Jul 18, 2019
Mark buffers read only after EOF has been received on a read
buffer watcher.
After an EOF has been received on a remote output stream,
mark the buffer read only for protection against future
errors.
As a temporary solution to issue #2239, add a new function
flux_subprocess_read_eof_reached(), allowing callers to see if the
internal read buffer has received EOF on the stream.
Copy link
Member

left a comment

Excellent, thanks. I'll mark this for merging once travis completes.

@mergify mergify bot merged commit 8a4d38f into flux-framework:master Jul 22, 2019
2 checks passed
2 checks passed
Summary 1 rule matches
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@codecov-io

This comment has been minimized.

Copy link

commented Jul 22, 2019

Codecov Report

Merging #2254 into master will decrease coverage by 0.01%.
The diff coverage is 52.63%.

@@            Coverage Diff             @@
##           master    #2254      +/-   ##
==========================================
- Coverage   80.77%   80.76%   -0.02%     
==========================================
  Files         209      209              
  Lines       33037    33056      +19     
==========================================
+ Hits        26686    26697      +11     
- Misses       6351     6359       +8
Impacted Files Coverage Δ
src/common/libflux/ev_buffer_read.c 93.67% <100%> (+0.08%) ⬆️
src/common/libsubprocess/remote.c 70% <50%> (-0.13%) ⬇️
src/common/libsubprocess/subprocess.c 86.85% <50%> (-1.16%) ⬇️
src/common/libflux/message.c 80.62% <0%> (-0.26%) ⬇️
src/common/libflux/mrpc.c 88.97% <0%> (+1.18%) ⬆️
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.