Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/flux-job: use job-info to obtain output in attach #2269

Merged
merged 1 commit into from Jul 25, 2019

Conversation

@garlick
Copy link
Member

commented Jul 25, 2019

Small change to flux job attach to use the job.info service rather than direct KVS access to fetch job output, since guests won't have direct KVS access.

The output handling code is just a super simple first cut that will need to be replaced anyway as we expand to cover more I/O modes (#2241), and it's not possible to write a test to verify that it works for guests since guests can run jobs yet, so the main value here is just getting implementation on track with the design so the next person modifying this code doesn't wind up wondering what's going on.

Problem: guests will not be able to access job output
because flux job attach fetches it directly from the KVS.

Use job-info.lookup to fetch output.

Fixes #2260
@grondo

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2019

Restarted one builder due to known valgrind issue #2195.

@grondo
grondo approved these changes Jul 25, 2019
Copy link
Contributor

left a comment

Seems perfectly reasonable for now. Setting merge-when-passing label.

@mergify mergify bot merged commit d29c568 into flux-framework:master Jul 25, 2019
2 checks passed
2 checks passed
Summary 1 rule matches
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.