Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add flux_job_kvs_namespace(3) and use it in job-exec for guest namespace #2315
Add a function to write the standard guest namespace for jobs into a buffer, to avoid users hand-coding an expected and possibly changing guest namespace name in scripts/code/etc.
Improve error usefulness by including the argument that failed to parse as unsigned in flux-job's parse_arg_unsigned() helper function.
Add a subcommand that converts flux job ids to namespace names, giving users and scripts a standard way to get kvs guest namespace names for jobs.
Switch to using libjob's flux_job_kvs_namespace() to create job guest kvs namespace names, instead of using the dothex notation of a flux_jobid_t. This puts job namespace name generation in a single place so that these names do not have to be generated manually anywhere, as well as allowing the naming convention to be updated in the future without breaking any existing code. As a side effect, this fixes a problematic side effect of kvs namespace names with periods in them, since these names are used as keys in kvs module stats output. Fixes #2306
@@ Coverage Diff @@ ## master #2315 +/- ## ========================================== + Coverage 80.87% 80.91% +0.03% ========================================== Files 214 214 Lines 33800 33815 +15 ========================================== + Hits 27337 27362 +25 + Misses 6463 6453 -10
garlick merged commit
Aug 16, 2019
4 checks passed
This was referenced
Aug 16, 2019
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews.