Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove flux-ps(1) #2327

Merged
merged 1 commit into from Aug 19, 2019

Conversation

@grondo
Copy link
Contributor

commented Aug 19, 2019

I noticed that flux ps appears in flux help output because there is still a flux-ps.1 manpage installed. Remove the manpage to avoid the sin of documenting a nonexistent command.

Problem: flux-ps is no longer a flux command, but has a manpage
installed and appears in flux help output.

Remove the old manpage so there is no trace of this command.
@chu11

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2019

doh, my bad! :-) approved, just set merge when passing.

@chu11
chu11 approved these changes Aug 19, 2019
@codecov-io

This comment has been minimized.

Copy link

commented Aug 19, 2019

Codecov Report

Merging #2327 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2327      +/-   ##
==========================================
- Coverage   80.91%   80.91%   -0.01%     
==========================================
  Files         214      214              
  Lines       33815    33815              
==========================================
- Hits        27361    27360       -1     
- Misses       6454     6455       +1
Impacted Files Coverage Δ
src/common/libflux/mrpc.c 87.79% <0%> (-1.19%) ⬇️
src/cmd/flux-module.c 83.72% <0%> (-0.24%) ⬇️
src/modules/connector-local/local.c 74.56% <0%> (+0.14%) ⬆️
src/common/libflux/message.c 80.88% <0%> (+0.25%) ⬆️
@mergify mergify bot merged commit d4904b8 into flux-framework:master Aug 19, 2019
4 checks passed
4 checks passed
Summary 1 rule matches
Details
codecov/patch Coverage not affected when comparing 9383f4d...936c8b1
Details
codecov/project 80.91% (-0.01%) compared to 9383f4d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@grondo

This comment has been minimized.

Copy link
Contributor Author

commented Aug 19, 2019

Thanks!

@grondo grondo deleted the grondo:no-flux-ps branch Aug 19, 2019
@garlick garlick referenced this pull request Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.