Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connectors/loop: Remove unused variables / do not accidentally close STDIN #2339

Merged
merged 2 commits into from Aug 27, 2019

Conversation

@chu11
Copy link
Contributor

commented Aug 27, 2019

As noted in #2337, several variables were unused in the loop connector. Of note, pollfd was unused, never initialized, but closed on context destruction. This lead to an accidental closing of STDIN (i.e. fd = 0).

chu11 added 2 commits Aug 26, 2019
Remove pollfd and pollevents variables from internal context.  The
variables are no longer used after commit:

d99344a

This has the side effect of fixing a bug in which STDIN (file descriptor
0) was accidentally closed when destroying the internal context.  This
occurred because the pollfd variable was never initialized and always
remained set to 0.

Fixes #2337
@chu11 chu11 force-pushed the chu11:issue2337 branch from d9acd56 to a766de7 Aug 27, 2019
@chu11

This comment has been minimized.

Copy link
Contributor Author

commented Aug 27, 2019

hit a spurious valgrind issue #2195, restarting builder

@garlick

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

Nice catch, and sorry for my sloppiness there! I'll go ahead and merge this now.

@garlick garlick merged commit c9ef033 into flux-framework:master Aug 27, 2019
2 checks passed
2 checks passed
Summary 1 potential rule
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@garlick garlick referenced this pull request Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.