Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
libsubprocess: cleanup + return error on bad cmd options #2343
Peeled off from #2329, some minor cleanups.
Also, in #2333 I detected invalid options for remote subprocesses and silently removed them. With the current set of options, it could go either way on silently removing vs return error to the user. But once we add I/O options, it really should be errors returned to the user if an option doesn't apply to a remote subprocess. So I now return an error to the user when an option doesn't apply to remote subprocesses.
Add new test where stdin is closed immediately on a subprocess. Make sure output callbacks are only called once for EOF.
@@ Coverage Diff @@ ## master #2343 +/- ## ========================================== + Coverage 80.82% 80.83% +0.01% ========================================== Files 215 215 Lines 34254 34254 ========================================== + Hits 27686 27690 +4 + Misses 6568 6564 -4