Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
misc cleanups & minor fixes #2360
This was referenced
Sep 11, 2019
Add flags for job-info.eventlog-watch and job-info.guest-eventlog-watch rpc calls for potential future feature support. In addition, support flags argument in flux_job_event_watch() in libjob.
On completion of watching the output eventlog, cancel the eventlog watch instead of simply destroying the future and exiting. This should avoid a potential matchtag leak.
During guest watch state transitions, there is a small racy scenario in which a user may cancel an event watch while the event watch is in the process or returning an error (ENOTSUP, etc.). Detect this cancellation and respond to the cancellation instead of moving onto the next state.
@@ Coverage Diff @@ ## master #2360 +/- ## ========================================= - Coverage 80.84% 80.8% -0.04% ========================================= Files 218 218 Lines 34501 34514 +13 ========================================= - Hits 27891 27889 -2 - Misses 6610 6625 +15
mergify bot merged commit
Sep 11, 2019
3 of 4 checks passed
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews.