Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
flux-in-flux: set jobid attribute #2362
As discussed in #2344, the
If flux is at instance level 0, the
This also drops the moribund
Problem: flux-proxy JOBID doesn't work anymore. The heuristic that translates a JOBID argument to a local:// URI no longer works because job ID's are now 64-bit, yet they are still passed through the 32-bit PMI appnum. Drop this support as it is fragile, and we can find other ways to look up URI's for jobs. Update flux-proxy(1) man page. Update proxy sharness test.
Problem: the 'session-id' attribute is intended to be the job ID of the flux instance, but it is passed through the 32-bit PMI appnum, so it gets mangled. Drop support for the 'session-id' attribute. Use the pid of the broker instead of the session id to construct the rundir and persistdir paths. Drop session-id from default boot.conf file. Update config file sharness test and its inputs.
Problem: if flux is booted via config file, the instance-level attribute is unset. Set it to zero if booted from a config file.
@@ Coverage Diff @@ ## master #2362 +/- ## ========================================== - Coverage 80.82% 80.82% -0.01% ========================================== Files 218 218 Lines 34530 34501 -29 ========================================== - Hits 27909 27884 -25 + Misses 6621 6617 -4
While working on this did you have any insight into how to propagate jobid from non-flux enclosing RM, e.g. to satisfy the strategy for libyogrt described in #2358?
Seems like this PR could go in as-is if our strategy for other RMs would be to place enclosing jobid into namespaced attribute, e.g.
Thanks for referencing that issue. It does seem like we would need something more than a number if
I guess I'm for doing that in a separate PR.