Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testsuite: valgrind test improvements #2400

Merged
merged 3 commits into from Sep 26, 2019

Conversation

@grondo
Copy link
Contributor

commented Sep 26, 2019

This PR adjusts the --killer-timeout for the valgrind test so that flux-start will be much less likely to kill brokers that are slow to exit.

Additionally, output is added to the current job workload to give better coverage during the valgrind run.

Finally, this may be controversial, but I noticed with make -j2 the fact that the valgrind and flux-in-flux tests were run last really seems to delay the overall time to complete make check. So, these tests are moved first in TESTS in Makefile.am, allowing them to start first and get better overlap with faster tests.

grondo added 3 commits Sep 26, 2019
Extend the default --killer-timeout for flux-start from 2s to 20.

This should resolve intermittent failures from the valgrind test
where the test itself completes, but one or more brokers is killed
by flux-start (presumably after the first one exits.)

Fixes #2195
Generate a couple lines of output in the valgrind.d/job workload,
just to get better coverage in the valgrind tests.

Fixes #2365
Move the long running tests t5000-valgrind.t and t3100-flux-in-flux.t
to the beginning of the TESTS list, so that they are started first
in `make check`. This should result in a lower makespan for `make check`
for `-j` > 1. (Especially on Travis where we can only run with -j2).
@codecov-io

This comment has been minimized.

Copy link

commented Sep 26, 2019

Codecov Report

Merging #2400 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2400      +/-   ##
==========================================
+ Coverage   81.05%   81.09%   +0.03%     
==========================================
  Files         223      223              
  Lines       35627    35627              
==========================================
+ Hits        28877    28891      +14     
+ Misses       6750     6736      -14
Impacted Files Coverage Δ
src/common/libflux/message.c 80.36% <0%> (+0.13%) ⬆️
src/cmd/flux-module.c 83.96% <0%> (+0.23%) ⬆️
src/common/libsubprocess/local.c 80.13% <0%> (+0.34%) ⬆️
src/modules/connector-local/local.c 74.27% <0%> (+1.16%) ⬆️
src/common/libflux/mrpc.c 88.97% <0%> (+1.18%) ⬆️
@garlick

This comment has been minimized.

Copy link
Member

commented Sep 26, 2019

Relief! Thank you.

@garlick garlick merged commit 317f80d into flux-framework:master Sep 26, 2019
4 checks passed
4 checks passed
Summary 1 potential rule
Details
codecov/patch Coverage not affected when comparing 84a9266...f55aa66
Details
codecov/project 81.09% (+0.03%) compared to 84a9266
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@grondo

This comment has been minimized.

Copy link
Contributor Author

commented Sep 26, 2019

Thanks!

@grondo grondo deleted the grondo:valgrind-fixes branch Sep 26, 2019
@garlick garlick referenced this pull request Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.