Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
testsuite: fix in-tree LUA_PATH to find correct fluxometer during tests #2404
Problem: on some Lua 5.2 systems, the current directory is last in the default LUA_PATH instead of first. This could result in flux Lua tests picking up the installed version of the test driver `fluxometer.lua` instead of the in-tree version. For in-tree flux(1), add the *explicit* path to fluxometer.lua, "$(top_builddir)/t/?.lua", to the "lua_path_add" libflux conf setting, to better ensure the right fluxometer is found in tests. Fixes #2403
Problem: on some systems `./?.lua` (the currend dir) is not always first in the default LUA_PATH. The lua-based tests in the testsuite depend on having this directory first in the path to ensure the correct fluxometer.lua is found during `make check`. Instead of assuming that the default empty LUA_PATH will work correctly, _always_ prepend "$(buiddir)/t/?.lua" to LUA_PATH in the testuite Makefile.am, to ensure that an incorrect system installed fluxometer.lua is not found during testing.
@@ Coverage Diff @@ ## master #2404 +/- ## ========================================== + Coverage 81.08% 81.11% +0.03% ========================================== Files 224 224 Lines 35770 35770 ========================================== + Hits 29004 29015 +11 + Misses 6766 6755 -11
garlick merged commit
Sep 28, 2019
4 checks passed
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews.