Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flux-version: make flux --version an alias, add manpage #2412

Merged
merged 4 commits into from Sep 30, 2019

Conversation

@grondo
Copy link
Contributor

commented Sep 30, 2019

This PR adds a simple manpage for flux-version(1) (allowing version to appear in output of flux-help(1).

Also, a quick hack is added to make flux -V, --version an alias for flux version (suggested by @SteVwonder)

It would be easy to just provide the flux-version manpage if the flux -V flag is a step too far.

grondo added 4 commits Sep 30, 2019
Add a convenience option -V, --version which simply execs flux-version.
Add -V, --version blurb to flux(1) manpage.
Ensure that flux -V, --version works the same as `flux version`.
Add a manpage for flux-version(1) so that `version` appears by
default in `flux help` output list of useful commands.

Fixes #2348
Copy link
Member

left a comment

LGTM! Feel free to set merge-when-passing when you're happy.

@codecov-io

This comment has been minimized.

Copy link

commented Sep 30, 2019

Codecov Report

Merging #2412 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2412      +/-   ##
==========================================
+ Coverage   81.11%   81.13%   +0.01%     
==========================================
  Files         225      225              
  Lines       36099    36102       +3     
==========================================
+ Hits        29283    29291       +8     
+ Misses       6816     6811       -5
Impacted Files Coverage Δ
src/cmd/flux.c 83.16% <100%> (+0.25%) ⬆️
src/common/libflux/message.c 80.36% <0%> (+0.13%) ⬆️
src/cmd/flux-job.c 85.26% <0%> (+0.28%) ⬆️
src/modules/job-info/watch.c 70.98% <0%> (+1.03%) ⬆️
@grondo grondo changed the title flux-version: make flux --version and alias and add manpage flux-version: make flux --version an alias, add manpage Sep 30, 2019
@mergify mergify bot merged commit 5ded3e7 into flux-framework:master Sep 30, 2019
4 checks passed
4 checks passed
Summary 1 rule matches
Details
codecov/patch 100% of diff hit (target 81.11%)
Details
codecov/project 81.13% (+0.01%) compared to 5f41697
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@grondo grondo deleted the grondo:doc-flux-version branch Sep 30, 2019
@garlick garlick referenced this pull request Sep 30, 2019
@SteVwonder

This comment has been minimized.

Copy link
Member

commented Oct 3, 2019

Thanks @grondo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.