Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump libflux-core.so version to 2 #2427

Merged
merged 1 commit into from Sep 30, 2019

Conversation

@garlick
Copy link
Member

commented Sep 30, 2019

Problem: ABI has changed in non-backwards compatible
ways since the 0.11 series.

Bump version 1 -> 2 on libflux-core.so only.

Fixes #2420

Problem: ABI has changed in non-backwards compatible
ways since the 0.11 series.

Bump version 1 -> 2 on libflux-core.so only.

Fixes #2420
@codecov-io

This comment has been minimized.

Copy link

commented Sep 30, 2019

Codecov Report

Merging #2427 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2427      +/-   ##
==========================================
- Coverage   81.15%   81.13%   -0.02%     
==========================================
  Files         225      225              
  Lines       36110    36110              
==========================================
- Hits        29304    29298       -6     
- Misses       6806     6812       +6
Impacted Files Coverage Δ
src/modules/connector-local/local.c 73.25% <0%> (-1.02%) ⬇️
src/broker/module.c 74.94% <0%> (-0.24%) ⬇️
src/common/libflux/message.c 80.22% <0%> (-0.14%) ⬇️
src/cmd/flux-module.c 84.19% <0%> (ø) ⬆️
src/shell/shell.c 86.02% <0%> (+0.26%) ⬆️
src/common/libsubprocess/local.c 80.2% <0%> (+0.34%) ⬆️
src/broker/modservice.c 71.42% <0%> (+0.75%) ⬆️
@grondo

This comment has been minimized.

Copy link
Contributor

commented Sep 30, 2019

Nice work!

@grondo grondo merged commit d91cedc into flux-framework:master Sep 30, 2019
4 checks passed
4 checks passed
Summary 1 potential rule
Details
codecov/patch Coverage not affected when comparing 0038f1b...b9e7d17
Details
codecov/project 81.13% (-0.02%) compared to 0038f1b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@garlick garlick deleted the garlick:libflux_core_version branch Sep 30, 2019
@garlick garlick referenced this pull request Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.