Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

job-ingest/validator: configure python shebang #2435

Merged
merged 1 commit into from Oct 1, 2019

Conversation

@garlick
Copy link
Member

commented Oct 1, 2019

Problem: validator.py uses #!/usr/bin/env python shebang,
which can pick up a user python without jsonschema installed.

Have configure substitute the configured python path instead.

Fixes #2434

Problem: validator.py uses #!/usr/bin/env python shebang,
which can pick up a user python without jsonschema installed.

Have configure substitute the configured python path instead.

Fixes #2434
@garlick garlick force-pushed the garlick:python_path branch from b6fc236 to d19a76c Oct 1, 2019
@grondo

This comment has been minimized.

Copy link
Contributor

commented Oct 1, 2019

Thanks for fixing this. LGTM.

@grondo
grondo approved these changes Oct 1, 2019
@mergify mergify bot merged commit c220e50 into flux-framework:master Oct 1, 2019
2 checks passed
2 checks passed
Summary 1 rule matches
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@codecov-io

This comment has been minimized.

Copy link

commented Oct 1, 2019

Codecov Report

Merging #2435 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2435      +/-   ##
==========================================
+ Coverage   81.13%   81.13%   +<.01%     
==========================================
  Files         225      225              
  Lines       36116    36116              
==========================================
+ Hits        29303    29304       +1     
+ Misses       6813     6812       -1
Impacted Files Coverage Δ
src/common/libflux/mrpc.c 87.79% <0%> (-1.19%) ⬇️
src/common/libutil/veb.c 98.42% <0%> (-0.53%) ⬇️
src/common/libsubprocess/local.c 79.86% <0%> (-0.35%) ⬇️
src/shell/shell.c 85.75% <0%> (-0.27%) ⬇️
src/common/libflux/message.c 80.36% <0%> (-0.14%) ⬇️
src/modules/connector-local/local.c 74.27% <0%> (+1.16%) ⬆️
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.