Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose optparse API publicly #702

Merged
merged 2 commits into from Jun 22, 2016

Conversation

Projects
None yet
3 participants
@garlick
Copy link
Member

garlick commented Jun 17, 2016

This PR moves optparse from a static library internal to flux-core to a public shared library, installed as ${libdir}/libflux-optparse.so and ${includedir}/flux/optparse.h.

This allows flux subcommands built outside of the core source tree to use the same option handling code, which should promote a more uniform user interface across framework components.

@garlick garlick added the review label Jun 17, 2016

@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Jun 17, 2016

Hm, does that mean we should do manpages for libflux-optparse? 😨

@garlick

This comment has been minimized.

Copy link
Member Author

garlick commented Jun 17, 2016

Maybe someday. IMHO not in this PR.

@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Jun 20, 2016

Looks like mpich.org is back up so I restarted the Travis build for this PR

@garlick

This comment has been minimized.

Copy link
Member Author

garlick commented Jun 20, 2016

Thanks!

Still no progress on travis-ci/apt-package-safelist#406 it seems.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 20, 2016

Coverage Status

Coverage decreased (-0.09%) to 75.161% when pulling 6439d49 on garlick:libflux-optparse into 9a65636 on flux-framework:master.

garlick added some commits Jun 17, 2016

liboptparse: externalize optparse
Build optparse as an installed shared library.
Install library to ${libdir}/libflux-optparse.so.
Install header to ${includedir}/flux/optparse.h
so it can be included with <flux/optparse.h>.

Note: also add src/include/flux/optparse.h wrapper,
so core sources can incdlue <flux/optparse.h> as well.
flux-core.pc: add -lflux-optparse
Add -lflux-optparse to flux-core.pc so that framework
projects can use optparse with minimal fuss.

@garlick garlick force-pushed the garlick:libflux-optparse branch from 6439d49 to 7d286fd Jun 21, 2016

@garlick

This comment has been minimized.

Copy link
Member Author

garlick commented Jun 21, 2016

Just rebased on current master and squashed the one incremental commit.

@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Jun 22, 2016

The coverage test got stuck between the two cron tests :-(. There was no information I could glean from the travis logs so I just restarted it.

Since everything else looked fine, is this ready to merge?

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 22, 2016

Coverage Status

Coverage decreased (-0.02%) to 75.216% when pulling 7d286fd on garlick:libflux-optparse into bb83fa6 on flux-framework:master.

@garlick

This comment has been minimized.

Copy link
Member Author

garlick commented Jun 22, 2016

Yep
On Jun 21, 2016 8:58 PM, "Coveralls" notifications@github.com wrote:

[image: Coverage Status] https://coveralls.io/builds/6699184

Coverage decreased (-0.02%) to 75.216% when pulling 7d286fd
7d286fd
on garlick:libflux-optparse
into bb83fa6
bb83fa6
on flux-framework:master
.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#702 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAKX2yaj1C8InbJx5kKp1Z27APfptvlsks5qOLLzgaJpZM4I4spj
.

@grondo grondo merged commit cef6e48 into flux-framework:master Jun 22, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.02%) to 75.216%
Details

@grondo grondo removed the review label Jun 22, 2016

@garlick garlick referenced this pull request Aug 2, 2016

Closed

0.4.0 release notes #739

@garlick garlick deleted the garlick:libflux-optparse branch Aug 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.