Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop sophia content store back end #727

Merged
merged 6 commits into from Jul 11, 2016

Conversation

Projects
None yet
3 participants
@garlick
Copy link
Member

garlick commented Jul 11, 2016

We've had two back ends for the content store since its inception, but only the sqlite one ever really gets used. The sophia back end requires the sophia database which we embedded. As a back end for the content store, sophia was never really properly tuned to use memory appropriately, and due to the lack of good documentation at the time, probably doesn't handle all error situations appropriately.

Now the embedded libsophia is outdated (issue #548), and is triggering some thread sanitizer warnings (issue #722).

This PR drops libsophia, the content-sophia module, and its sharness test.

@garlick garlick added the review label Jul 11, 2016

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 11, 2016

Coverage Status

Coverage increased (+0.2%) to 75.655% when pulling 4e343dd on garlick:drop_sophia into 0a7613e on flux-framework:master.

@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Jul 11, 2016

Looks good! Is sophia still mentioned in the flux-content(1) man page?

git grep sophia on this branch might also show some other lingering references. (e.g. you could also remove the -i src/common/libsophia argument in cppcheck.sh if you have not already)

@garlick

This comment has been minimized.

Copy link
Member Author

garlick commented Jul 11, 2016

Oh yeah, git grep - I always forget about that one. Thanks, just pushed a couple more changes as a result.

@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Jul 11, 2016

Thanks! I'll merge this once travis is green.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 11, 2016

Coverage Status

Coverage increased (+0.2%) to 75.639% when pulling 6b09973 on garlick:drop_sophia into 0a7613e on flux-framework:master.

@grondo grondo merged commit 78980c6 into flux-framework:master Jul 11, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 75.639%
Details

@grondo grondo removed the review label Jul 11, 2016

@garlick garlick deleted the garlick:drop_sophia branch Jul 11, 2016

@garlick garlick referenced this pull request Aug 2, 2016

Closed

0.4.0 release notes #739

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.