Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: kvs_watch fix #759

Merged
merged 3 commits into from Aug 12, 2016

Conversation

Projects
None yet
5 participants
@SteVwonder
Copy link
Member

SteVwonder commented Aug 12, 2016

Fixes an error that occurs when kvs_watch returns a NULL value.

Also added in the dropcache funtion to the python bindings and cleaned up some unused imports.

Fixes: #752

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Aug 12, 2016

Current coverage is 74.69% (diff: 100%)

Merging #759 into master will decrease coverage by 0.04%

@@             master       #759   diff @@
==========================================
  Files           145        145          
  Lines         25010      25010          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          18694      18682    -12   
- Misses         6316       6328    +12   
  Partials          0          0          

Powered by Codecov. Last update 274c3dc...15bed90

@dongahn

This comment has been minimized.

Copy link
Contributor

dongahn commented Aug 12, 2016

Nice work! Very minor nit. In the commit message: ENONET -> ENOENT.

@SteVwonder

This comment has been minimized.

Copy link
Member Author

SteVwonder commented Aug 12, 2016

Nice catch @dongahn, I mistyped that in the code originally as well. Re-push coming shortly.

@SteVwonder SteVwonder force-pushed the SteVwonder:python-kvs-watch-fix branch from 071217f to 3260cc4 Aug 12, 2016

@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 12, 2016

Coverage Status

Coverage increased (+0.01%) to 75.002% when pulling 3260cc4 on SteVwonder:python-kvs-watch-fix into 178328f on flux-framework:master.

SteVwonder added some commits Aug 11, 2016

python: fix error when kvs_watch returns NULL val
ffi.string errors when it is passed a NULL pointer, so check if the
errnum is ENOENT (indicating that the value is NULL), and then set value
to None, avoiding a call to ffi.string

@SteVwonder SteVwonder force-pushed the SteVwonder:python-kvs-watch-fix branch from 3260cc4 to 15bed90 Aug 12, 2016

@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 12, 2016

Coverage Status

Coverage decreased (-0.03%) to 75.017% when pulling 15bed90 on SteVwonder:python-kvs-watch-fix into 274c3dc on flux-framework:master.

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Aug 12, 2016

Looks good - is it feasible to add a test for this behavior?

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Aug 12, 2016

Actually we are going to need to make a new tag - shall I go ahead and merge this now so it goes in?

@dongahn

This comment has been minimized.

Copy link
Contributor

dongahn commented Aug 12, 2016

+1 because it seems an obvious fix and side effect unlikely.

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Aug 12, 2016

OK, merging.

@garlick garlick merged commit d494fee into flux-framework:master Aug 12, 2016

4 checks passed

codecov/patch Coverage not affected when comparing 274c3dc...15bed90
Details
codecov/project Absolute coverage decreased by -0.04% but relative coverage increased by +25.25% compared to 274c3dc
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.03%) to 75.017%
Details

@SteVwonder SteVwonder deleted the SteVwonder:python-kvs-watch-fix branch Feb 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.