Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autogen.sh: run libtoolize before autoreconf #771

Merged
merged 1 commit into from Aug 16, 2016

Conversation

Projects
None yet
6 participants
@grondo
Copy link
Contributor

grondo commented Aug 16, 2016

While I don't understand why it is necessary, and it might just be an artifact of the way spack works, I don't exactly see the harm in an extra call to libtoolize at the top of autogen.sh, and this also gives us an opportunity to update flux-core autogen.sh to use autoreconf.

@trws or @SteVwonder, can you see if this fixes spack build for flux-core?

Fixes #770

autogen.sh: run libtoolize before autoreconf
Update autogen.sh to use autoreconf instead of running each
autotools step separately. Additionally add extra call to libtoolize
*before* autoreconf to ensure libtool macros that are not in default
aclocal path are copied/linked in-tree for aclocal.

@grondo grondo added the review label Aug 16, 2016

@trws

This comment has been minimized.

Copy link
Member

trws commented Aug 16, 2016

Thanks @grondo, I'll check it out shortly, it should solve the autogen issue but we'll still have the python module RPATH issue (completely not a flux problem).


Sent from Boxer | http://getboxer.comhttp://bxr.io/PBI3C

On August 16, 2016 at 10:41:13 AM PDT, Mark Grondona notifications@github.com wrote:

While I don't understand why it is necessary, and it might just be an artifact of the way spack works, I don't exactly see the harm in an extra call to libtoolize at the top of autogen.sh, and this also gives us an opportunity to update flux-core autogen.sh to use autoreconf.

@trwshttps://github.com/trws or @SteVwonderhttps://github.com/SteVwonder, can you see if this fixes spack build for flux-core?

Fixes #770#770


You can view, comment on, or merge this pull request online at:

#771

Commit Summary

  • autogen.sh: run libtoolize before autoreconf

File Changes

  • M autogen.shhttps://github.com//pull/771/files#diff-0 (19)

Patch Links:

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//pull/771, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAoStf-68AfzEm4iSwug1q5WDj1xWqlKks5qgfYxgaJpZM4Jlqts.

@grondo

This comment has been minimized.

Copy link
Contributor Author

grondo commented Aug 16, 2016

Ah, oops, you can ignore my comment in #770 then, I missed that there were 2 issues here....

@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 16, 2016

Coverage Status

Coverage increased (+0.02%) to 75.104% when pulling bbf00a5 on grondo:autogen-update into b8249b4 on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Aug 16, 2016

Current coverage is 74.78% (diff: 100%)

Merging #771 into master will increase coverage by 0.01%

@@             master       #771   diff @@
==========================================
  Files           145        145          
  Lines         25022      25022          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          18708      18713     +5   
+ Misses         6314       6309     -5   
  Partials          0          0          

Powered by Codecov. Last update b8249b4...bbf00a5

@SteVwonder

This comment has been minimized.

Copy link
Member

SteVwonder commented Aug 16, 2016

@trws, I have a fix for the py-cffi RPATH problem here: spack/spack#1527
But the spack unit test seems to be failing for reasons unrelated to my change.

@SteVwonder

This comment has been minimized.

Copy link
Member

SteVwonder commented Aug 16, 2016

@grondo: this does fix the problem with building under spack (assuming the py-cffi fix is pulled into spack's master).

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Aug 16, 2016

Fine by me. Merge?

@trws

This comment has been minimized.

Copy link
Member

trws commented Aug 16, 2016

I'm all for it.

@grondo

This comment has been minimized.

Copy link
Contributor Author

grondo commented Aug 16, 2016

Sure

On Tue, Aug 16, 2016 at 2:29 PM, Tom Scogland notifications@github.com
wrote:

I'm all for it.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#771 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAtSUvn7xATn1SAkje1KvOQ2bkod_5giks5qgiu0gaJpZM4Jlqts
.

@garlick garlick merged commit 1df7925 into flux-framework:master Aug 16, 2016

4 checks passed

codecov/patch Coverage not affected when comparing b8249b4...bbf00a5
Details
codecov/project 74.78% (+0.01%) compared to b8249b4
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 75.104%
Details

@garlick garlick removed the review label Aug 16, 2016

@grondo grondo deleted the grondo:autogen-update branch Sep 15, 2016

@garlick garlick referenced this pull request Oct 26, 2016

Closed

0.5.0 release notes #879

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.