Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
implement scalable reduction for wireup protocol #781
This PR should speed up the "hello" protocol executed during wireup a little bit.
The new protocol uses TBON topology-informed reduction to reduce a count. Once the count reaches the target size wireup is complete.
I guess this is also another simple example of how the reduction handle works.
See long comment in ddc83ef
Current coverage is 74.75% (diff: 78.43%)
@@ master #781 diff @@ ========================================== Files 145 145 Lines 25037 25038 +1 Methods 0 0 Messages 0 0 Branches 0 0 ========================================== - Hits 18723 18716 -7 - Misses 6314 6322 +8 Partials 0 0
I had noted a problem with this PR where the timeout values were not being calculated properly in the reduction handle. The topology information was used to scale the timeout based on the level in the TBON and the topology was read using the wrong attribute interface for broker-resident services.
I decided the scaling of timeout values was counter-intuitive for the user and ought to be the user's responsibility to set up if it is needed, and so removed it from the
I also rebased on current master, and now I think it's ready for merge consideration.