Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: add a check for invalid handle types #819

Merged
merged 1 commit into from Sep 23, 2016

Conversation

Projects
None yet
5 participants
@trws
Copy link
Member

trws commented Sep 23, 2016

Fixes an invalid test, adds a new test for the corrected behavior and a
check with assertions, and test, for the invalid assignment that caused
the initial issue.

fixes #818

python: add a check for invalid handle types
Fixes an invalid test, adds a new test for the corrected behavior and a
check with assertions, and test, for the invalid assignment that caused
the initial issue.

@garlick garlick added the review label Sep 23, 2016

@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 23, 2016

Coverage Status

Coverage increased (+0.02%) to 75.272% when pulling 5228e2b on trws:use-after-free-test into 170d0b1 on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Sep 23, 2016

Current coverage is 74.95% (diff: 100%)

Merging #819 into master will increase coverage by 0.01%

@@             master       #819   diff @@
==========================================
  Files           145        145          
  Lines         24911      24911          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          18668      18672     +4   
+ Misses         6243       6239     -4   
  Partials          0          0          

Powered by Codecov. Last update 170d0b1...5228e2b

@grondo

grondo approved these changes Sep 23, 2016

Copy link
Contributor

grondo left a comment

Seems great to me as far as I can review it. Thanks for the quick fix @trws !

@trws

This comment has been minimized.

Copy link
Member Author

trws commented Sep 23, 2016

Should be good to go if someone wants to hit the button.

@grondo grondo merged commit 400a743 into flux-framework:master Sep 23, 2016

4 checks passed

codecov/patch Coverage not affected when comparing 170d0b1...5228e2b
Details
codecov/project 74.95% (+0.01%) compared to 170d0b1
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 75.272%
Details
@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Sep 23, 2016

I will!

@grondo grondo removed the review label Sep 23, 2016

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Sep 23, 2016

Cherry picked onto my branch with the rpc use-after-free assertions and works. Thanks!

@trws

This comment has been minimized.

Copy link
Member Author

trws commented Sep 23, 2016

Happy to, and thanks for the references to those commits @garlick, they
helped track down the issue when I was putting this PR together.

On 23 Sep 2016, at 10:30, Jim Garlick wrote:

Cherry picked onto my branch with the rpc use-after-free assertions
and works. Thanks!

You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#819 (comment)

@garlick garlick referenced this pull request Oct 26, 2016

Closed

0.5.0 release notes #879

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.