Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
kvs: add kvs_getat() and related functions #824
Resubmitting work from the withdrawn PR #820, cleaned up:
This PR adds the following new KVS interfaces:
/* Like kvs_get() but lookup is relative to 'treeobj'. */ int kvs_getat (flux_t h, const char *treeobj, const char *key, char **json_str); int kvs_get_dirat (flux_t h, const char *treeobj, const char *key, kvsdir_t **dirp); int kvs_get_symlinkat (flux_t h, const char *treeobj, const char *key, char **val);
and modifies the
I also implemented @grondo's suggestion of making
I spent a long time agonizing over the API here, and came to the conclusion (again) that a sweeping KVS API overhaul is necessary and that these additions should stick to the original theme for the time being.
Current coverage is 75.05% (diff: 72.96%)
@@ master #824 diff @@ ========================================== Files 146 146 Lines 25287 25410 +123 Methods 0 0 Messages 0 0 Branches 0 0 ========================================== + Hits 18943 19071 +128 + Misses 6344 6339 -5 Partials 0 0
This was referenced
Sep 29, 2016
Hmm, I don't recall seeing a jsc error that looks like this. Will have a look tomorrow.
I think improving coverage further here will have diminishing returns as the KVS API is due to for a complete rethink soon, and most of the coverage issues are in the "client" portion of the code. In addition, coverage overall has improved in this PR.