Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security: Remove pointer from typedef flux_sec_t #830

Merged
merged 1 commit into from Oct 4, 2016

Conversation

Projects
None yet
4 participants
@morrone
Copy link
Contributor

morrone commented Oct 4, 2016

Remove the pointer from the definition of the typedef
flux_sec_t to comply with the Coding Style Guide and
to make it easier to use.

security: Remove pointer from typedef flux_sec_t
Remove the pointer from the definition of the typedef
flux_sec_t to comply with the Coding Style Guide and
to make it easier to use.

@garlick garlick added the review label Oct 4, 2016

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 4, 2016

Coverage Status

Coverage remained the same at 75.325% when pulling 16d917b on morrone:unpointer_flux_sec_t into a8793ce on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 4, 2016

Current coverage is 75.01% (diff: 62.06%)

Merging #830 into master will not change coverage

@@             master       #830   diff @@
==========================================
  Files           146        146          
  Lines         25410      25410          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          19062      19062          
  Misses         6348       6348          
  Partials          0          0          
Diff Coverage File Path
••••• 59% src/common/libflux/security.c
•••••••••• 100% src/cmd/flux-snoop.c
•••••••••• 100% src/broker/overlay.c
•••••••••• 100% src/cmd/flux-keygen.c
•••••••••• 100% src/broker/broker.c
•••••••••• 100% src/broker/snoop.c

Powered by Codecov. Last update a8793ce...16d917b

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Oct 4, 2016

Nice - I have to leave at the moment, will give this a closer look tomorrow. Thanks!

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Oct 4, 2016

Oh sheesh, actually looks pretty obviously good. Merging!

@garlick garlick merged commit fb19bd9 into flux-framework:master Oct 4, 2016

3 of 4 checks passed

codecov/patch 62.06% of diff hit (target 75.01%)
Details
codecov/project 75.01% remains the same compared to a8793ce
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 75.325%
Details

@garlick garlick removed the review label Oct 4, 2016

@morrone morrone deleted the morrone:unpointer_flux_sec_t branch Oct 11, 2016

@garlick garlick referenced this pull request Oct 26, 2016

Closed

0.5.0 release notes #879

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.