Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module: Remove pointer from typedef flux_modlist_t #831

Merged
merged 1 commit into from Oct 4, 2016

Conversation

Projects
None yet
5 participants
@morrone
Copy link
Contributor

morrone commented Oct 4, 2016

Remove the pointer from the definition of the typedef
flux_modlist_t to comply with the Coding Style Guide and
to make it easier to use.

flux-sched will need a one-line change to accommodate
this change.

module: Remove pointer from typedef flux_modlist_t
Remove the pointer from the definition of the typedef
flux_modlist_t to comply with the Coding Style Guide and
to make it easier to use.

flux-sched will need a one-line change to accomodate
this change.

@garlick garlick added the review label Oct 4, 2016

@morrone

This comment has been minimized.

Copy link
Contributor Author

morrone commented Oct 4, 2016

Is this reasonable? How much work do we need to do to coordinate a change in flux-core and flux-sched?

@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Oct 4, 2016

Is this reasonable? How much work do we need to do to coordinate a change in flux-core and flux-sched?

That is a good question. Typically, we've opened a PR in flux-core and flux-sched simultaneously, with instructions to merge flux-core first, then flux-sched (which uses flux-core master for continuous integration checks). Feel free to add the necessary changes to flux-sched and open a PR there.

Once flux-core interfaces have stabilized, we'll likely have less of these types of changes going on, or we can base other framework projects off a "stable" branch of flux-core, then forward-port them to flux-core master/new stable branch as necessary (but we haven't actually planned that far ahead yet)

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 4, 2016

Coverage Status

Coverage decreased (-0.004%) to 75.318% when pulling 9718ae8 on morrone:unpointer_flux_modlist_t into fb19bd9 on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 4, 2016

Current coverage is 75.00% (diff: 91.66%)

Merging #831 into master will decrease coverage by <.01%

@@             master       #831   diff @@
==========================================
  Files           146        146          
  Lines         25410      25410          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          19061      19060     -1   
- Misses         6349       6350     +1   
  Partials          0          0          
Diff Coverage File Path
••••••••• 90% src/common/libflux/module.c
•••••••••• 100% src/cmd/flux-module.c
•••••••••• 100% src/broker/module.c
•••••••••• 100% src/broker/broker.c

Powered by Codecov. Last update fb19bd9...9718ae8

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Oct 4, 2016

@morrone would you mind submitting the flux-sched one liner with note as @grondo described.
I'll merge this once that PR is submitted - this looks good.

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Oct 4, 2016

Thanks - just saw flux-framework/flux-sched#205. Merging this one.

@garlick garlick merged commit 323aa53 into flux-framework:master Oct 4, 2016

4 checks passed

codecov/patch 91.66% of diff hit (target 75.01%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +16.65% compared to fb19bd9
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.004%) to 75.318%
Details

@garlick garlick removed the review label Oct 4, 2016

@morrone morrone deleted the morrone:unpointer_flux_modlist_t branch Oct 11, 2016

@garlick garlick referenced this pull request Oct 26, 2016

Closed

0.5.0 release notes #879

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.