Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove JSON typedef, just use json_object * #832

Merged
merged 1 commit into from Oct 4, 2016

Conversation

Projects
None yet
4 participants
@morrone
Copy link
Contributor

morrone commented Oct 4, 2016

Remove the JSON typedef, and in its place use json_object * directly.
The JSON typedef proved to be more obfuscation than beneficial.

Remove JSON typedef, just use json_object *
Remove the JSON typedef, and in its place use json_object * directly.
The JSON typedef proved to be more obfuscation than beneficial.

@garlick garlick added the review label Oct 4, 2016

@morrone

This comment has been minimized.

Copy link
Contributor Author

morrone commented Oct 4, 2016

It looks like flux-sched has some JSON as well. But there might be no interdependency because flux-sched just has a straight copy of shortjson.h.

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Oct 4, 2016

Yay! Waiting for travis.

Shouldn't affect sched.

@morrone

This comment has been minimized.

Copy link
Contributor Author

morrone commented Oct 4, 2016

Whoops. Looks like I flubbed somewhere.

@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Oct 4, 2016

Thanks, wow!

One of the Travis builds hung, but I'm unsure why. I just restarted it.

@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Oct 4, 2016

Whoops. Looks like I flubbed somewhere.

I don't think so... we do have some known intermittent failures of make check under travis-ci. Sometimes when there is a failure, one of the builds just needs to be restarted. I apologize for that.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 4, 2016

Coverage Status

Coverage decreased (-0.03%) to 75.342% when pulling 37ae2b3 on morrone:json_object_pointer into 323aa53 on flux-framework:master.

@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Oct 4, 2016

Looks good now!

@grondo grondo merged commit dc58fcb into flux-framework:master Oct 4, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.03%) to 75.342%
Details

@grondo grondo removed the review label Oct 4, 2016

@morrone morrone deleted the morrone:json_object_pointer branch Oct 11, 2016

@garlick garlick referenced this pull request Oct 26, 2016

Closed

0.5.0 release notes #879

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.